Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsSql outbox Isn't operating in UTC Time #2194

Closed
preardon opened this issue Jul 19, 2022 · 3 comments
Closed

MsSql outbox Isn't operating in UTC Time #2194

preardon opened this issue Jul 19, 2022 · 3 comments
Assignees
@preardon
Labels
3 - Done Bug

Comments

@preardon
Copy link
Member

MsSql outbox

Brighter/src/Paramore.Brighter.Outbox.MsSql/MsSqlOutbox.cs

Line 533 in 454599d

var pagingSqlFormat = "SELECT * FROM (SELECT ROW_NUMBER() OVER(ORDER BY Timestamp ASC) AS NUMBER, * FROM {0} WHERE DISPATCHED IS NULL) AS TBL WHERE TIMESTAMP < DATEADD(millisecond, -@OutStandingSince, getdate()) AND NUMBER BETWEEN ((@PageNumber-1)*@PageSize+1) AND (@PageNumber*@PageSize) ORDER BY Timestamp ASC";

Brighter/src/Paramore.Brighter.Outbox.MsSql/MsSqlOutbox.cs

Line 502 in 454599d

var pagingSqlFormat = "SELECT * FROM (SELECT ROW_NUMBER() OVER(ORDER BY Timestamp DESC) AS NUMBER, * FROM {0}) AS TBL WHERE DISPATCHED IS NOT NULL AND DISPATCHED < DATEADD(millisecond, @OutStandingSince, getdate()) AND NUMBER BETWEEN ((@PageNumber-1)*@PageSize+1) AND (@PageNumber*@PageSize) ORDER BY Timestamp DESC";

catalintoma pushed a commit to catalintoma/Brighter that referenced this issue Jul 19, 2022
BrighterCommand#2194 [CT] Using UTC in MSSQL / MYSQL outbox, as this …
6d79676 
…is the timezone used when storing messages
catalintoma pushed a commit to catalintoma/Brighter that referenced this issue Jul 20, 2022
@catalintoma
BrighterCommand#2194 [CT] Using UTC in MSSQL / MYSQL outbox, as this …
f60801e 
…is the timezone used when storing messages
catalintoma added a commit to catalintoma/Brighter that referenced this issue Jul 20, 2022
@catalintoma
BrighterCommand#2194 [CT] Using built-in MySQL functions, imposing ou…
85c2dd8 
…tbox dates to be stored in UTC
preardon pushed a commit that referenced this issue Jul 20, 2022
@catalintoma
#2194 [CT] Using UTC in MSSQL / MYSQL outbox, as this is the timezone… (
05ccea7 
#2196)

* #2194 [CT] Using UTC in MSSQL / MYSQL outbox, as this is the timezone used when storing messages

* #2194 [CT] Using built-in MySQL functions, imposing outbox dates to be stored in UTC

Co-authored-by: Catalin Toma <[email protected]>
@iancooper
Copy link
Member

@preardon is this done?

@preardon
Copy link
Member Author

@iancooper

@catalintoma fixed this for us

@iancooper
Copy link
Member

Thanks @catalintoma will close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@preardon preardon

Labels
3 - Done Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iancooper @preardon