Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASB - add integration test(s) for ASB #1442

Closed
penderi opened this issue Mar 18, 2021 · 6 comments
Closed

ASB - add integration test(s) for ASB #1442

penderi opened this issue Mar 18, 2021 · 6 comments
Assignees
@penderi
Labels
1 - Up Next Bug grabbed by assignee

Comments

@penderi
Copy link
Contributor

penderi commented Mar 18, 2021 •
edited
Loading

We need coverage to ensure ASB transport is working.

Add at least one happy path test(s), following the SQS/SNS example by allowing:

  • specifying credentials in environmental variables
  • running against a real ASB instance

mentioned in #1438
@penderi penderi mentioned this issue Mar 18, 2021
Merged
@penderi penderi changed the title ASB - Add integration test(s) for ASB ASB - add integration test(s) for ASB Mar 18, 2021
@iancooper
Copy link
Member

@preardon @penderi Where are we on this one?

@preardon
Copy link
Member

@iancooper do we have an ASB that we can use in the pipeline for integration tests?

@iancooper
Copy link
Member

Not at the moment, but I can set one up, I have enough free credits. We just need to crank necessary secrets into GitHb

preardon added a commit to preardon/Brighter that referenced this issue Sep 25, 2021
@preardon
Added Integration test for ASB as well patching more properties throu…
3604b77 
…gh to the infrastructure BrighterCommand#1442
@preardon
Copy link
Member

There is one basic Integration Test now, also fixed some things that weren't being patches through

@preardon
Copy link
Member

PR in now #1727

preardon added a commit to preardon/Brighter that referenced this issue Sep 25, 2021
@preardon
Added Integration test for ASB as well patching more properties throu…
594c464 
…gh to the infrastructure BrighterCommand#1442
iancooper added a commit that referenced this issue Sep 27, 2021
@preardon @iancooper
Added Integration test for ASB #1442 (#1727)
a7f133d 
* Fix the build Issues in DI & the Test for RPC Subscriptions

* Added Integration test for ASB as well patching more properties through to the infrastructure #1442

Co-authored-by: Ian Cooper <[email protected]>
@preardon
Copy link
Member

@iancooper This can now be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@penderi penderi

Labels
1 - Up Next Bug grabbed by assignee
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iancooper @penderi @preardon