allow missing CVR headers #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to then add some basic validation checks to make sure that each candidate column has characters? I created a .csv generic_csv_test_cvr_2.csv that has a blank candidate name and I get the following error. 
|
|
Good catch -- yes, will need to fix that. |
artoonie
force-pushed
the
bugfix/issue-813_cvr-missing-header
branch
from
f0f4b40 to
ec6879d
Compare
|
Fixed -- it took a bit more work than expected, the built-in header parser really doesn't like null header names, even though it's fairly common practice in CVRs/Spreadsheets to have empty headers...go ahead and give this a whirl? |
success!
|
HEdingfield
reviewed
Jun 14, 2024
src/test/resources/network/brightspots/rcv/test_data/generic_csv_test/generic_csv_test_cvr.csv
Outdated
Show resolved
Hide resolved
artoonie
force-pushed
the
bugfix/issue-813_cvr-missing-header
branch
from
43ffd86 to
e92bf84
Compare
HEdingfield
reviewed
Jun 16, 2024
HEdingfield
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #813
This type of CSV is allowed and I don't see a reason to not support it. Added a test to account for it.
Because
getHeaderNamesskips all null/empty columns, I had to move away from using the built-in header parser.I also put the
Generic CSV Writerbehind aencounteredSourceProblemflag since it will lead to more exceptions on failure.