new GUI modal: tabulation confirmation page

config/spotbugs/exclude.xml

@@ -30,4 +30,17 @@
     <Field name="xmlns"/>
     <Bug code="UrF"/>
   </Match>
+  <Match>
+    <Class name="~network\.brightspots\.rcv\.GuiTabulateController"/>
+    <Method name="initialize"/>
+    <Bug code="EI2"/>
+  </Match>
+  <Match>
+    <Class name="~network\.brightspots\.rcv\.TabulatorSession\$LoadedCvrData"/>
+    <Bug code="EI2"/>
+  </Match>
+  <Match>
+    <Class name="~network\.brightspots\.rcv\.TabulatorSession\$LoadedCvrData"/>
+    <Bug code="EI"/>
+  </Match>
 </FindBugsFilter>

src/main/java/network/brightspots/rcv/ContestConfig.java

@@ -501,7 +501,7 @@ Set<ValidationError> validate() {
       Logger.info("Contest config validation successful.");
     } else {
       Logger.severe(
-          "Contest config validation failed! Please modify the contest config file and try again.\n"
+          "Contest config validation failed! Modify the contest config file and try again.\n"
               + "See config_file_documentation.txt for more details.");
     }
     return validationErrors;
@@ -545,8 +545,8 @@ private void validateOutputSettings() {
           Logger.severe(
               "To ensure read-only access to RCTab output files, users must not"
                   + " set the output path to user account folders like Documents,"
-                  + " Desktop, etc. -- any path under \"%s\" is prohibited. Please"
-                  + " specify a new path outside this folder in the Output tab of the"
+                  + " Desktop, etc. -- any path under \"%s\" is prohibited."
+                  + " Specify a new path outside this folder in the Output tab of the"
                   + " app (e.g. C:\\RCTab\\output).",
               rootUsersDirectory);
         }

src/main/java/network/brightspots/rcv/ContestConfigMigration.java

@@ -95,7 +95,7 @@ static void migrateConfigVersion(ContestConfig config)
               WinnerElectionMode.MULTI_SEAT_SEQUENTIAL_WINNER_TAKES_ALL.getInternalLabel();
           default -> {
             Logger.warning(
-                "winnerElectionMode \"%s\" is unrecognized! Please supply a valid "
+                "winnerElectionMode \"%s\" is unrecognized! Supply a valid "
                     + "winnerElectionMode.",
                 oldWinnerElectionMode);
             rules.winnerElectionMode = null;
@@ -123,8 +123,7 @@ static void migrateConfigVersion(ContestConfig config)
           rules.tiebreakMode = tiebreakModeMigrationMap.get(oldTiebreakMode).getInternalLabel();
         } else {
           Logger.warning(
-              "tiebreakMode \"%s\" is unrecognized! Please supply a valid tiebreakMode.",
-              oldTiebreakMode);
+              "tiebreakMode \"%s\" is unrecognized! Supply a valid tiebreakMode.", oldTiebreakMode);
           rules.tiebreakMode = null;
         }
       }

src/main/java/network/brightspots/rcv/CsvCvrReader.java

@@ -90,6 +90,7 @@ void readCastVoteRecords(List<CastVoteRecord> castVoteRecords)
           }
           int rankAsInt;
           try {
+            rankAsString = rankAsString.trim();
             rankAsInt = Integer.parseInt(rankAsString);
           } catch (NumberFormatException e) {
             Logger.severe(

src/main/java/network/brightspots/rcv/DominionCvrReader.java

@@ -273,8 +273,9 @@ private int parseCvrFile(
       String batchId = session.get("BatchId").toString();
       Integer recordId = (Integer) session.get("RecordId");
       String suppliedId = recordId.toString();
-      String computedId = Stream.of(tabulatorId, batchId, Integer.toString(recordId))
-              .filter(s -> s != null && !s.isEmpty())
+      String computedId =
+          Stream.of(tabulatorId, batchId, Integer.toString(recordId))
+              .filter(s -> s != null && !s.isBlank())
               .collect(Collectors.joining("|"));
 
       // filter out records which are not current and replace them with adjudicated ones