Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include a "#" column on candidate and CVR list #810

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

artoonie
Copy link
Collaborator

@artoonie artoonie commented Mar 15, 2024

closes #674

Done for both the candidate and CVR list
Adapted from this code: https://stackoverflow.com/a/41282740/1057105 (do we want to include a reference to s/o in the code?)

@yezr
Copy link
Collaborator

yezr commented Mar 15, 2024

Yes, let's also add to the candidate list.

@artoonie artoonie requested a review from HEdingfield March 15, 2024 21:41
Copy link
Contributor

@tarheel tarheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by startNumber. It looks like you always pass 1 for this arg and you never change the value. But there must be something in the interface that modifies this value...?

Adapted from this code: https://stackoverflow.com/a/41282740/1057105 (do we want to include a reference to s/o in the code?)

Might as well.

@artoonie
Copy link
Collaborator Author

startNumber is basically there to swap between 0-index and 1-index, in case we want a table with 0-indexing in the future -- it could also be used to have a partially-loaded table, e.g. if we decide to list all CVRs in the GUI and dynamically load just a segment.

(It came free from s/o so I opted to not delete it.)

@artoonie artoonie merged commit 2ac2291 into develop Mar 25, 2024
1 check passed
@artoonie artoonie deleted the feature/issue-674 branch March 25, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List total number of CVR files added on CVR Files tab
3 participants