lib: don't use util.inspect() internals

This makes sure the internal `stylize` function is not used to render anything and instead just uses the regular inspect function in case of reaching the maximum depth level. PR-URL: nodejs#24971 Refs: nodejs#24765 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BridgeAR · Feb 28, 2019 · be78266 · be78266
1 parent 6c52ef9
commit be78266
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/lib/internal/encoding.js b/lib/internal/encoding.js
@@ -320,7 +320,7 @@ class TextEncoder {
   [inspect](depth, opts) {
     validateEncoder(this);
     if (typeof depth === 'number' && depth < 0)
-      return opts.stylize('[Object]', 'special');
+      return this;
     var ctor = getConstructorOf(this);
     var obj = Object.create({
       constructor: ctor === null ? TextEncoder : ctor
@@ -517,7 +517,7 @@ function makeTextDecoderJS() {
       [inspect](depth, opts) {
         validateDecoder(this);
         if (typeof depth === 'number' && depth < 0)
-          return opts.stylize('[Object]', 'special');
+          return this;
         var ctor = getConstructorOf(this);
         var obj = Object.create({
           constructor: ctor === null ? TextDecoder : ctor

diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -343,7 +343,7 @@ class URL {
     }
 
     if (typeof depth === 'number' && depth < 0)
-      return opts.stylize('[Object]', 'special');
+      return this;
 
     var ctor = getConstructorOf(this);
 

diff --git a/test/parallel/test-whatwg-encoding-custom-textdecoder.js b/test/parallel/test-whatwg-encoding-custom-textdecoder.js
@@ -134,7 +134,7 @@ if (common.hasIntl) {
 // Test TextDecoder inspect with negative depth
 {
   const dec = new TextDecoder();
-  assert.strictEqual(util.inspect(dec, { depth: -1 }), '[Object]');
+  assert.strictEqual(util.inspect(dec, { depth: -1 }), '[TextDecoder]');
 }
 
 {

diff --git a/test/parallel/test-whatwg-url-custom-inspect.js b/test/parallel/test-whatwg-url-custom-inspect.js
@@ -63,7 +63,7 @@ assert.strictEqual(
 
 assert.strictEqual(
   util.inspect({ a: url }, { depth: 0 }),
-  '{ a: [Object] }');
+  '{ a: [URL] }');
 
 class MyURL extends URL {}
 assert(util.inspect(new MyURL(url.href)).startsWith('MyURL {'));