console: don't use ANSI escape codes when TERM=dumb

PR-URL: nodejs#26261 Fixes: nodejs#26187 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
BridgeAR · Mar 21, 2019 · 9952375 · 9952375
1 parent 5f032a7
commit 9952375
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/lib/internal/console/constructor.js b/lib/internal/console/constructor.js
@@ -346,7 +346,7 @@ const consoleMethods = {
   clear() {
     // It only makes sense to clear if _stdout is a TTY.
     // Otherwise, do nothing.
-    if (this._stdout.isTTY) {
+    if (this._stdout.isTTY && process.env.TERM !== 'dumb') {
       // The require is here intentionally to avoid readline being
       // required too early when console is first loaded.
       const { cursorTo, clearScreenDown } = require('readline');

diff --git a/test/pseudo-tty/console-dumb-tty.js b/test/pseudo-tty/console-dumb-tty.js
@@ -0,0 +1,9 @@
+'use strict';
+require('../common');
+
+process.env.TERM = 'dumb';
+
+console.log({ foo: 'bar' });
+console.dir({ foo: 'bar' });
+console.log('%s q', 'string');
+console.log('%o with object format param', { foo: 'bar' });
diff --git a/test/pseudo-tty/console-dumb-tty.out b/test/pseudo-tty/console-dumb-tty.out
@@ -0,0 +1,4 @@
+{ foo: 'bar' }
+{ foo: 'bar' }
+string q
+{ foo: 'bar' } with object format param