Skip to content

Commit

Permalink
readline: make Symbol.asyncIterator support stable
Browse files Browse the repository at this point in the history
PR-URL: nodejs#26989
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
  • Loading branch information
mcollina committed Apr 3, 2019
1 parent 1d8298a commit 4de5e0a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 5 additions & 1 deletion doc/api/readline.md
Original file line number Diff line number Diff line change
Expand Up @@ -312,9 +312,13 @@ The `rl.write()` method will write the data to the `readline` `Interface`'s
### rl\[Symbol.asyncIterator\]()
<!-- YAML
added: v11.4.0
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/26989
description: Symbol.asyncIterator support is no longer experimental.
-->

> Stability: 1 - Experimental
> Stability: 2 - Stable
* Returns: {AsyncIterator}

Expand Down
3 changes: 0 additions & 3 deletions lib/readline.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ const {
} = require('internal/errors').codes;
const { validateString } = require('internal/validators');
const { inspect } = require('internal/util/inspect');
const { emitExperimentalWarning } = require('internal/util');
const EventEmitter = require('events');
const {
CSI,
Expand Down Expand Up @@ -1075,8 +1074,6 @@ Interface.prototype._ttyWrite = function(s, key) {
};

Interface.prototype[Symbol.asyncIterator] = function() {
emitExperimentalWarning('readline Interface [Symbol.asyncIterator]');

if (this[kLineObjectStream] === undefined) {
if (Readable === undefined) {
Readable = require('stream').Readable;
Expand Down

0 comments on commit 4de5e0a

Please sign in to comment.