fixing BtTextEdit so that it saves text on exit #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderwm
referenced
this pull request
in kapinga/brewtarget
Aug 4, 2017
TBH, I'm not sure this connection does anything at all, but at least it now has an appropriate signal/slot pair
|
@rocketman768 I have tested the pull request and it looks good. |
|
@dpettersson thanks! Go ahead and approve/merge. |
dpettersson
approved these changes
Aug 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not being able to save the notes finally broke me. The textChanged signal was being overridden so it was never triggered, changing the function name works for me. Should fix #365