Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanism to add new content #750

Closed
kalilbispo opened this issue May 8, 2023 · 8 comments
Closed

Mechanism to add new content #750

kalilbispo opened this issue May 8, 2023 · 8 comments

Comments

@kalilbispo
Copy link

First of all, thank you so much for your app.

This is not an issue or a bug, but rather a suggestion. Could you please add plugins to Brewtarget that allow users to add new content such as:

  • Style Guidelines
  • Yeast brands or kveiks
  • Water profiles
  • Unmalted and malted grains
  • Miscellaneous ingredients

I believe that using plugins to add content would be preferable to doing it manually

@matty0ung
Copy link
Contributor

Glad you're finding Brewtarget useful.

When you say "plugins", do you mean a way to import styles and yeasts and so on from another program? Or is it something else? If you could give an example that might be helpful for me to understand.

You can currently import things from BeerXML (mostly, though there are some inherent problems with BeerXML that sometimes make this a bit fiddly).

In the not too distant future (I hope), it will be possible to import things from BeerJSON. (I have it working for Hops and Fermentables, and am slowly working through the other importable things!)

@kalilbispo
Copy link
Author

When I used the term 'plugin,' I was referring to a user-friendly and developer-friendly solution. Specifically, I envision a feature where users can easily import Swaen, Agraria, or BestMalz into their malt list by simply clicking a button within the program itself, without the need for BeerXML or even external solutions.

@matty0ung
Copy link
Contributor

So you'd like to be able to import all the malts from a particular maltster at the click of a button? That would be a neat feature 😸 but it might be a bit tricky without the cooperation of all the maltsters to make their data available in a common format. (IDK if they could be persuaded on the grounds that it is for the benefit of their customers.)

Alternatively, maybe, if it turned out that all malt spec sheets were sufficiently similar, there might be a clever way to parse them with BeautifulSoup, Scrapy or some such. Depending on how "standard" the spec sheets are, it could turn out to be a bit fiddly to write though. If it were feasible, and someone had the time to tackle it, I would think the best approach IMHO would be to code a free-standing external tool that converts spec sheets into BeerJSON and then have Brewtarget ingest that. But, as ever, am open to suggestions.

@kalilbispo
Copy link
Author

I think I can help you in this task

@Kalilovisky
Copy link

Dear Matt, I am writing to inform you that I have sent you an invitation to join my GitHub project. I would greatly appreciate your feedback on the BeerJSON tool and whether you think it meets our requirements.
https://github.com/Kalilovisky/BeerJSON_Tool_for_Brewers

@matty0ung
Copy link
Contributor

Definitely looks like a good idea if you already have all the data in spreadsheets.

If you have data for Hops or Fermentables, then we can already try importing it. I usually find with these sorts of things that it's quite an iterative process getting the parsing and writing working.

@Kalilovisky
Copy link

Kalilovisky commented May 15, 2023 via email

@matty0ung matty0ung changed the title Plugins for add new content Mechanism to add new content Jul 29, 2024
@matty0ung
Copy link
Contributor

I'm going to close this as the implementation of BeerJSON means we do now have a modern way to add new content -- eg see https://github.com/Brewtarget/brewtarget/blob/develop/data/DefaultContent003-Ingredients-Hops-Yeasts.json

I had a quick look at https://github.com/Kalilovisky/BeerJSON_Tool_for_Brewers/blob/main/Hop.json. It looks promising, in terms of containing a lot of records. I couldn't yet load it as it's not quite the right format and it's a bit fiddly to edit without line-breaks, but I'll put some more specific comments in a ticket in that repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants