Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water chemistry was misbehaving #705

Closed
mikfire opened this issue Dec 31, 2022 · 0 comments
Closed

Water chemistry was misbehaving #705

mikfire opened this issue Dec 31, 2022 · 0 comments

Comments

@mikfire
Copy link
Contributor

mikfire commented Dec 31, 2022

I use the water chemistry feature heavily, and it wasn't working.

It came down to two major issues. The first was, as we discussed in another thread, the intializer for the Salt was not right. amount_is_weight, amount and addTo just are miswired.

The other problem was that BtTableModel::removeDuplicate was removing both duplicates and things marked as either deleted or to not be displayed. I am uncertain of that logic, but it certainly wasn't right for Salts as they are always marked as not displayed.

A pull request will be made directly.

matty0ung added a commit that referenced this issue Jan 2, 2023
Water chemistry misbehaving -- closes #705
matty0ung pushed a commit to matty0ung/brewken that referenced this issue Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant