Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific heat label fix (cal/(g*K)) to (Cal/(g*K)) #404

Closed
pricelessbrewing opened this issue Mar 23, 2018 · 2 comments
Closed

Specific heat label fix (cal/(g*K)) to (Cal/(g*K)) #404

pricelessbrewing opened this issue Mar 23, 2018 · 2 comments
Assignees

Comments

@pricelessbrewing
Copy link
Contributor

According to the brewtargets typical values for specific heat (0.12 for aluminum), this should be labelled as a function of Cal, not cal. Otherwise aluminum would have a typical value of 0.00012.

I'll take this on as my first commit. Should be pretty straight forward, change to equipment UI, and manual, no changes to formulas or anything.

@dpettersson
Copy link
Contributor

Assigning to @pricelessbrewing. Looking forward to reviewing :)

@pricelessbrewing
Copy link
Contributor Author

Going with (Cal/(g*C)) since deltas in C and K are equivalent, and the Kelvin scale is not a supported temperature system. Moreover it is then equivalent with the standard in most software I'm aware of, which might be easier in the event that specific heat for equipment is ever part of the BeerXML/BeerJSON standard.

pricelessbrewing added a commit to pricelessbrewing/brewtarget that referenced this issue Mar 24, 2018
Fixes Brewtarget#404 for label in equipment editor. Image 7 on page 10 of the PDF needs to be updated accordingly. No text needs to be changed in the manual.
dpettersson added a commit that referenced this issue Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants