Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mash designer produces inconsistent results #279

Closed
mattipt opened this issue Jun 17, 2016 · 3 comments
Closed

Mash designer produces inconsistent results #279

mattipt opened this issue Jun 17, 2016 · 3 comments
Assignees
Milestone

Comments

@mattipt
Copy link

mattipt commented Jun 17, 2016

I am having trouble with the mash designer. When I drag one slider around, the other sliders' values do not seem to update correctly. So for example when I drag the 'infusion/decoction amount' to its maximum value, the resulting infusion temp and total collected wort values vary wildly on repeated attempts.

Here's an example, setting infusion/decoction amount to its maximum value of 16.789 litres:
Try 1: infusion temp 77.174 C, total collected wort 8.876 l
Try 2: infusion temp 76.098 C, total collected wort 10.760 l
Try 3: infusion temp 82.910 C, total collected wort 3.586 l

This may have something to do with Brewtarget not updating the other fields fast enough when the mouse cursor reaches the end of the slider (and some change event is lost?) I don't know it it's related to the fact that the widgets themselves seem to be annoyingly resizing themselves to accommodate the changing numerical values.

I'm running Brewtarget 2.3.0 on Mac OS X.

@mattipt
Copy link
Author

mattipt commented Jun 17, 2016

After a bit more investigation, it seems like the problem is still present on git head, with some additional oddities meaning not all slider values update automatically. I wrote a small patch that seems to fix the sliders mash designer for me; it's at http://enneu.net/files/mashdesigner.patch

The GUI glitch of widgets jittering while resizing to content remains.

Apart from that issue, the mash designer seems to have some other bugs too but I assume these are already known:

  1. Selecting Batch Sparge as the step type has no effect on the range of the amount slider (used to work in 2.3 I believe.)
  2. If hitting the target temperature would result in water hotter than boiling, the temperature slider reverses, with a higher-than-boiling temperature as its minimum value and boiling point as the maximum.

@rocketman768
Copy link
Member

Yeah, definitely seems like some events get lost when I move the slider fast. I'll post a pull request with your patch for review (you can also do this instead of a patch if you find bugs in the future).

@rocketman768
Copy link
Member

rocketman768 commented Jun 19, 2016

I'm splitting the other two issues you mentioned into other issues :)

mikfire added a commit that referenced this issue Jun 24, 2016
…ents

Fixes #279: mash designer slider value inconsistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants