Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location override feature #63

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

nikhil153
Copy link
Contributor

@Breakend Here is a PR for the issue we discussed (#57). It provides an option to specify region coordinates (longitude and latitude) for the cluster location. In unspecified, it defaults to the original ping the ipinfo.io approach.

I am not entirely clear on why location is queried by both the gather_initial_info() and _sample_and_log_power() functions, but regardless I have updated both of these to use specified longitude and latitude of the region.

Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant