Merge pull request #63 from ram170/card-empty-state

Empty states are not handled in about page contributors card #60
BrandonArmand · Oct 1, 2020 · 2c6a0a9 · 2c6a0a9
2 parents 643721b + 60a9025
commit 2c6a0a9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/views/About/components/Card.js b/src/views/About/components/Card.js
@@ -10,6 +10,7 @@ import Button from "components/CustomButtons/Button.js";
 import Tooltip from "@material-ui/core/Tooltip";
 import { styles } from "assets/jss/material-kit-react/views/about/components/cardStyle";
 import PropTypes from "prop-types";
+import { showDetail } from "../helpers";
 
 const useStyles = makeStyles(styles);
 
@@ -42,7 +43,7 @@ const ContributorCard = props => {
                                     <i className="fas fa-globe" /> Website
                                 </Button>
                             )}
-                            {props.commits && (
+                            {showDetail(props.commits) && (
                                 <Tooltip
                                     title="Commits"
                                     placement="right"
@@ -57,7 +58,7 @@ const ContributorCard = props => {
                                     </div>
                                 </Tooltip>
                             )}
-                            {props.additions && (
+                            {showDetail(props.additions) && (
                                 <Tooltip
                                     title="Additions"
                                     placement="right"
@@ -72,7 +73,7 @@ const ContributorCard = props => {
                                     </div>
                                 </Tooltip>
                             )}
-                            {props.deletions && (
+                            {showDetail(props.deletions) && (
                                 <Tooltip
                                     title="Deletions"
                                     placement="right"

diff --git a/src/views/About/helpers.js b/src/views/About/helpers.js
@@ -9,3 +9,7 @@ export function commitDel(arr) {
         return (typeof a.d != "undefined" ? a.d : a) + b.d;
     });
 }
+
+export function showDetail(val) {
+    return val ? true : null;
+}