Tree Tent Test Suite #775
Merged
Tree Tent Test Suite #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One valid case of connecting a tree to a tent One invalid case of connecting a tree to a tent when there is another valid tent
Looks like the case rule was implemented incorrectly :/
Actually case generator works properly
When the clue is that there are 0 tents, the case returned should be equivalent to FinishWithGrass.
Expected to create four cases, each one connecting a line between the tree in the center and one of the four surrounding trees.
With one tree, one case is created. With no trees, no cases are created. With diagonal trees, no cases are created.
Removed double-calling setCell due to custom and super mouseReleased
Similar test cases to LinkTentCaseRule - Make sure diagonal tents have no bearing on cases - Make sure no tents around the tree fails - One tent should connect to the correct tree - Two tents should create two cases - No other cases to check, as there cannot be more than two tents around a tree; otherwise, the tents would touch
Rewrote recursive generate board function to be slightly more optimized
Fixes a bug where you couldn't apply the FillInRow Case Rule on a child node
When checking the proof tree, the Puzzle Importer only checks for changed cells. However, for TreeTent, the user can create lines, which cannot be saved as a "cell" object. Now, an importer class can override the getImporterElements function to specify what types of changes the board may experience.
Simple mistake in calculation of index
|
Converting this PR to a draft since it seems to be WIP |
Adjust all simple cases to also check the central column rule
Checks that the rule works on an empty 5x5 board
All Direct Rules
The Ubuntu and Checkstyle Autocompilers have trouble opening this file for some reason
…EGUP_FORK into TreeTent-Test-Suite
|
I have no idea why the Ubuntu and Checkstyle actions are failing when loading the file for one of the FillInRowCaseRule tests. I'll just comment it out for now. |
charlestian23
approved these changes
May 5, 2024
This was referenced Oct 3, 2024
This was referenced Oct 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Tree Tent Test suite
Bug Fixes
Closes #608, #609, #610, #611, #757, #768
Type of change
How Has This Been Tested?
I was able to create and reopen TreeTent puzzles with various sizes. After making a few moves while solving a puzzle, placing a line, and saving the puzzle, I was able to reopen it.
Checklist: