Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightup Documentation and Test Suite (Computability and Logic Project) #538

Merged
merged 14 commits into from
Apr 14, 2023

Conversation

Jimmers2001
Copy link
Collaborator

Description

The following PR implements a test suite, checking the validity of the contradiction, basic, and case rules by using many small example boards.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ X ] Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

More information about the tests can be found here: shorturl.at/cuvQV

Checklist:

  • [ X ] I have performed a self-review of my code
  • [ X ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • [ X ] My changes generate no new warnings
  • [ X ] I have added tests that prove my fix is effective or that my feature works
  • [X ] New and existing unit tests pass locally with my changes

Doesnt pass but after more research on specifics of the rule, it should be the right structure and a good example.
There was a requirement that no squares be gray because that invites the potential for bulbs to be there and satisfy the black tile instead of having a too few bulbs contradiction.
prints "out of bounds" although for a 3x3 grid it should be within bounds
A test that completes 3 tiles and another test that completes 1 tile
Should add more examples but the basic one works
@charlestian23 charlestian23 self-assigned this Apr 14, 2023
@charlestian23 charlestian23 self-requested a review April 14, 2023 13:58
@charlestian23 charlestian23 merged commit 0039649 into Bram-Hub:dev Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants