Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit Puzzle Clear Data #531

Merged
merged 9 commits into from
Apr 14, 2023
Merged

Conversation

19690ao
Copy link
Collaborator

@19690ao 19690ao commented Apr 9, 2023

Description

Both the proof and puzzle editors didn't have proper implementation for the exit button. They switched panels without changing the underlying data of the puzzle itself. This caused strange behavior, like asking if you wanted to open a new puzzle after exiting or breaking the puzzle creator after exiting a proof.

The exit button should work properly now.

Closes #265

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Since a problem would only show up after exiting from an editor and entering an editor from the Home Panel, there were 6 variations of the issue. I tested them individually as best I could.

Proof->exit->Solve
Proof->exit->Create
Proof->exit->Edit
Puzzle->exit->Solve
Puzzle->exit->Create
Puzzle->exit->Edit

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@charlestian23 charlestian23 self-requested a review April 14, 2023 13:59
@charlestian23 charlestian23 self-assigned this Apr 14, 2023
Copy link
Collaborator

@charlestian23 charlestian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good

@charlestian23 charlestian23 merged commit dc66807 into Bram-Hub:dev Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants