BasicRule_Generic Circular Reasoning

[19690ao]

Description

Unlike most puzzles' basic/direct rules, the rules for short truth tables are either direct or indirect subclasses of an abstract class called BasicRule_Generic. This rule happened to have a self-justification bug, which happened to affect every single basic rule in STT.

Prof. Bram noticed the one that affected BasicRuleAtomic (#417), but that was one of many.

For example, using biconditional elimination:

...and a less obvious example using or elimination:

Although this transition is invalid, this bug is the reason that one of those cells is validated even though they're both equally part of the problem.

TLDR: Many STT basic rules have been bugged, possibly since its creation. I tried it on my build of Legup from LMS back from last year's intro to logic course, and I was able to reproduce the same behavior

Closes #417

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Enhancement (improvement to an already existing feature)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (if applicable)
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[charlestian23]

I just pushed a change to dev that refactors a lot of files. Can you pull that onto your branch and fix any merge conflicts?

[charlestian23]

Changes seem good!