-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Add dark mode #404
Comments
Note that using Flatlaf may also allow us to implement dark mode and light mode |
I added the dependency and changed the look & feel here @charlestian23 please pull and give it a look see how you like it |
Open a pull request and I'll review it there |
Ok you can check it out here, probably shouldn't make PRs for things that shouldn't be merged? |
My apologies, I thought you meant it was ready to be reviewed. I marked your pull request as a draft, and you can mark it as ready for review when you’re done. |
Well it is ready for review? It just replaces the legup look and feel with flatlaf. Probably don't want to merge it in unless you're happy with the 1:1 replacement |
Oh the pull request won't automatically merge without my approval. You can create the pull request when you finish working on the issue, and I don't like the result I can always reject the merge. |
@N-Desmarais Do you want to work on implementing a dark mode as well or were you interested in working on something else? |
@charlestian23 FlatLightLaf -> FlatDarkLaf? |
Yeah, but we'd also need to create an option in the menu for users to select whether they want dark mode or light mode. The software would then need to change depending on what is selected. |
* [ENHANCEMENT] Add dark mode #404 * Changed all instances of "night mode" to "dark mode" --------- Co-authored-by: charlestian23 <[email protected]>
Describe the current behavior of what you're trying to improve. If your enhancement request related to a problem, please also describe the problem.
Since we are starting to update the UI icons to be more modern, I felt that changing the overall UI feel of Legup (and not just the icons), would be suitable.
Describe the improvement you'd like
Consider using FlatLaf in Legup to give it a more modern feel.
Describe alternatives you've considered
We can consider looking into other open source options to improve UI.
Additional Context
No response
The text was updated successfully, but these errors were encountered: