Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add dark mode #404

Closed
2 tasks done
charlestian23 opened this issue Dec 30, 2022 · 10 comments
Closed
2 tasks done

[ENHANCEMENT] Add dark mode #404

charlestian23 opened this issue Dec 30, 2022 · 10 comments
Assignees
Labels
enhancement Improvement to existing feature good first issue Good for newcomers new feature Request for a new feature ui

Comments

@charlestian23
Copy link
Collaborator

charlestian23 commented Dec 30, 2022

Describe the current behavior of what you're trying to improve. If your enhancement request related to a problem, please also describe the problem.

Since we are starting to update the UI icons to be more modern, I felt that changing the overall UI feel of Legup (and not just the icons), would be suitable.

  • Implement FlatLaf look and feel
  • Implement the ability for the user to toggle between light mode and dark mode

Describe the improvement you'd like

Consider using FlatLaf in Legup to give it a more modern feel.

Describe alternatives you've considered

We can consider looking into other open source options to improve UI.

Additional Context

No response

@charlestian23 charlestian23 added enhancement Improvement to existing feature new feature Request for a new feature ui labels Dec 30, 2022
@charlestian23 charlestian23 self-assigned this Dec 30, 2022
@charlestian23
Copy link
Collaborator Author

Note that using Flatlaf may also allow us to implement dark mode and light mode

@charlestian23 charlestian23 changed the title [ENHANCEMENT] Use FlatLaf to modernize Legup UI [ENHANCEMENT] Use FlatLaf to modernize Legup UI (and add dark mode + light mode) Jan 6, 2023
@charlestian23 charlestian23 removed their assignment Jan 25, 2023
@charlestian23 charlestian23 added the good first issue Good for newcomers label Jan 25, 2023
@N-Desmarais N-Desmarais self-assigned this Jan 31, 2023
@N-Desmarais
Copy link
Collaborator

N-Desmarais commented Jan 31, 2023

I added the dependency and changed the look & feel here

@charlestian23 please pull and give it a look see how you like it

@charlestian23
Copy link
Collaborator Author

I added the dependency and changed the look & feel here

@charlestian23 please pull and give it a look see how you like it

Open a pull request and I'll review it there

@N-Desmarais
Copy link
Collaborator

N-Desmarais commented Feb 3, 2023

Ok you can check it out here, probably shouldn't make PRs for things that shouldn't be merged?

@charlestian23
Copy link
Collaborator Author

My apologies, I thought you meant it was ready to be reviewed. I marked your pull request as a draft, and you can mark it as ready for review when you’re done.

@N-Desmarais
Copy link
Collaborator

Well it is ready for review? It just replaces the legup look and feel with flatlaf. Probably don't want to merge it in unless you're happy with the 1:1 replacement

@charlestian23
Copy link
Collaborator Author

Oh the pull request won't automatically merge without my approval. You can create the pull request when you finish working on the issue, and I don't like the result I can always reject the merge.

@charlestian23
Copy link
Collaborator Author

@N-Desmarais Do you want to work on implementing a dark mode as well or were you interested in working on something else?

@N-Desmarais
Copy link
Collaborator

@charlestian23 FlatLightLaf -> FlatDarkLaf?

@charlestian23
Copy link
Collaborator Author

Yeah, but we'd also need to create an option in the menu for users to select whether they want dark mode or light mode. The software would then need to change depending on what is selected.

@charlestian23 charlestian23 changed the title [ENHANCEMENT] Use FlatLaf to modernize Legup UI (and add dark mode + light mode) [ENHANCEMENT] Add dark mode Feb 10, 2023
@kevinkxu kevinkxu self-assigned this Feb 10, 2023
kevinkxu added a commit to kevinkxu/LEGUP that referenced this issue Feb 18, 2023
charlestian23 added a commit that referenced this issue Feb 24, 2023
* [ENHANCEMENT] Add dark mode #404

* Changed all instances of "night mode" to "dark mode"

---------

Co-authored-by: charlestian23 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing feature good first issue Good for newcomers new feature Request for a new feature ui
Projects
None yet
Development

No branches or pull requests

3 participants