Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Change yt-dlp failures to warnings, validate script/server output directly #39

Merged
merged 8 commits into from
Dec 25, 2024
Merged

[test] Change yt-dlp failures to warnings, validate script/server output directly #39

merged 8 commits into from
Dec 25, 2024

Conversation

Brainicism
Copy link
Owner

@Brainicism Brainicism commented Dec 24, 2024 •
edited
Loading

  • Test script output is correct (non-null POT and visitor ID)
  • Test server response is correct (non-null POT and visitor ID)
  • Change yt-dlp failures to warnings (failures are expected due to bot check)

@Brainicism Brainicism force-pushed the fix-tests branch 5 times, most recently from f9a3440 to b8509c9 Compare December 24, 2024 15:34
@Brainicism Brainicism changed the title wip Fix tests Dec 24, 2024
@Brainicism Brainicism requested a review from grqz December 24, 2024 15:37
@Brainicism Brainicism marked this pull request as ready for review December 24, 2024 15:38
@Brainicism Brainicism changed the title Fix tests [test] Change yt-dlp failures to warnings, validate script/server output directly Dec 25, 2024
grqx
grqx reviewed Dec 25, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
grqz
grqz approved these changes Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@grqz grqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brainicism Brainicism merged commit 8a5dded into master Dec 25, 2024
3 checks passed
@Brainicism Brainicism deleted the fix-tests branch December 25, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grqx grqx grqx left review comments

@grqz grqz grqz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brainicism @grqz @grqx