Update RE5 mesh and material custom attributes #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryOfCarim
changed the title
Reserved values shouldn't matter at all but tests require them to be the same
- ValueError wasn't correct - Remove test for group reserved value
Now it uses vtype in materials_data
- remove unused vertex color import logic - expose 2 mesh flags, they probably do nothing but require investigation - revert serialization for Groups' reversed param
Brachi
reviewed
Aug 20, 2024
albam/engines/mtfw/texture.py
Outdated
| 3: "maskmap", | ||
| 4: "lightmap", | ||
| 5: "shadowmap", | ||
| 6: "additionalmap", |
There was a problem hiding this comment.
what is additional map? Is it original?
There was a problem hiding this comment.
The additional map is _AM, a black and white mask used in some stages for transparency
albam/engines/mtfw/texture.py
Outdated
| @@ -57,6 +57,19 @@ class TextureType(Enum): # TODO: TextureTypeSlot | |||
| SPECULAR_BLEND = 22 | |||
|
|
|||
|
|
|||
| SYMBOL_TEX_TYPES = { | |||
There was a problem hiding this comment.
Instead of creating yet another mapping, wouldn't it better to add these to TextureType?
It shouldn't break any non-re5 code since we don't use the number directly, just the name.
There was a problem hiding this comment.
I changed the logic in the last commit to use TEX_TYPE_MAP_2 dictionary, not sure is it the best idea
| - {id: vdeclbase, type: u1} | ||
| - {id: vdecl, type: u1} | ||
| - {id: vertex_position, type: u2} # min_index | ||
| - {id: num_weight_bounds, type: u1} # probably num of OABB boundng volumes |
There was a problem hiding this comment.
Nit: I think this was confirmed long ago, just with a bad name (there was a TODO to rename it), so the comment can be removed
- adress issues
Brachi
requested changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.