Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline models don't take model slots #17

Merged
merged 12 commits into from
Sep 24, 2024
Merged

inline models don't take model slots #17

merged 12 commits into from
Sep 24, 2024

Conversation

BraXi
Copy link
Owner

@BraXi BraXi commented Sep 24, 2024

The changes to inline models:

  • inline models are not written to config strings, thus are not sent to client, the client knows all bmodels anyway since they're stored in BSP
  • inline models no longer take svmodel_s slots, thus they're no longer counting towards MAX_MODELS limit
  • all inline models (except the BSP world model) are accessed via negative model indexes
  • the net protocol does send models as short, allowing for 65k models in total, since modelindexes can be negative sending them as char/byte is a bit too limiting
  • a bit more strict renderer api check that verifies shared struct sizes

@BraXi BraXi merged commit c529894 into main Sep 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant