WIP: Tidy up preload script #2595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the if/else conversion to case statements are fine but I fail to see how anything else is an improvement... it looks harder to read/understand and is multiple lines longer. |
|
also shellcheck shows a syntax error. refer to the action log |
| @@ -37,25 +37,18 @@ function error { | |||
| exit 1 | |||
| } | |||
|
|
|||
| #yad or xlunch format | |||
| case "$1" in | |||
| source) return 0 ;; | |||
There was a problem hiding this comment.
The preload script is not to be sourced. Why has this input argument been added?
| fi | ||
| # The prefix is a category to preload. By default (if '/' or empty) the main | ||
| # page is preloaded. | ||
| test "$2" = / || prefix="$2" |
There was a problem hiding this comment.
this breaks the prefix variable and thus the preload script, it is no longer set when it is not /
theofficialgman
added
changes requested
waiting on response
|
Closing as stale as the author has not implemented requested changes and the if statement to case conversion makes no functional difference (we can implement that whenever if we wanted). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of optimizations and cleanups for preload.