-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring needed for the reference doc #124
Conversation
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
===========================================
- Coverage 81.12% 55.41% -25.72%
===========================================
Files 68 72 +4
Lines 1563 1662 +99
Branches 193 300 +107
===========================================
- Hits 1268 921 -347
- Misses 260 631 +371
- Partials 35 110 +75
Continue to review full report at Codecov.
|
LGTM but conflicting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
However, this introduces some breaking changes:
getValue
-> botGet
setValue
-> botSet
brain.initUserIfNecessary
-> brain.addUserIfNecessary
adapter.initUserIfNecessary
-> adapter.addUserIfNecessary
So I think the commit should begin with "breaking change: ".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe we could have model classes for user and conversation instead of methods
No description provided.