Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring needed for the reference doc #124

Merged
merged 3 commits into from
Feb 28, 2018
Merged

Conversation

yangeorget
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 28, 2018

Codecov Report

Merging #124 into master will decrease coverage by 25.71%.
The diff coverage is 57.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #124       +/-   ##
===========================================
- Coverage   81.12%   55.41%   -25.72%     
===========================================
  Files          68       72        +4     
  Lines        1563     1662       +99     
  Branches      193      300      +107     
===========================================
- Hits         1268      921      -347     
- Misses        260      631      +371     
- Partials       35      110       +75
Impacted Files Coverage Δ
...s/botfuel-dialog/src/adapters/messenger-adapter.js 27.61% <0%> (ø) ⬆️
packages/botfuel-dialog/src/adapters/adapter.js 57.14% <0%> (-42.86%) ⬇️
packages/botfuel-dialog/src/brains/memory-brain.js 96.36% <100%> (-3.64%) ⬇️
packages/botfuel-dialog/src/brains/mongo-brain.js 94.2% <100%> (-4.35%) ⬇️
packages/botfuel-dialog/src/brains/brain.js 55.55% <66.66%> (-44.45%) ⬇️
.../botfuel-dialog/src/errors/authentication-error.js 0% <0%> (-100%) ⬇️
...otfuel-dialog/src/messages/quickreplies-message.js 0% <0%> (-100%) ⬇️
...tfuel-dialog/src/extractors/composite-extractor.js 0% <0%> (-100%) ⬇️
packages/botfuel-dialog/src/adapter-resolver.js 0% <0%> (-100%) ⬇️
packages/botfuel-dialog/src/loggers/debug.js 0% <0%> (-100%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbdab82...e6189f4. Read the comment docs.

@yangeorget
Copy link
Contributor Author

LGTM but conflicting

@michelbl michelbl self-requested a review February 28, 2018 16:57
Copy link
Contributor

@michelbl michelbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, this introduces some breaking changes:
getValue -> botGet
setValue -> botSet
brain.initUserIfNecessary -> brain.addUserIfNecessary
adapter.initUserIfNecessary -> adapter.addUserIfNecessary
So I think the commit should begin with "breaking change: ".

Copy link
Contributor

@KevinDepuydt KevinDepuydt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe we could have model classes for user and conversation instead of methods

@yangeorget yangeorget merged commit 19bed17 into master Feb 28, 2018
@yangeorget yangeorget deleted the brainrefactoring branch February 28, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants