-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add, change and fix some mappings #544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work, thank you so much for you contribution.
This is a significant change. Please describe the new (common, generic) tags which are added with this PR. Describe what they are used for, maybe what the originating (native) tags are. Link to the original tag documentation where possible.
Thanks you so much for the documentation, that looks very good @ozelot379 . There are some small lint errors, you could possibly fix them in the mean time ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add unit test demonstrating these mappings?
@Borewit But I had to change the follow too to make it work:
I think it's a small breaking change, but at least the other unit tests are not broken |
…is more consistent with existing code.
@ozelot379. I think there is room for improvement in the unit tests. I have no problem with a reference to the original issue, but the unit test should describe which feature it is testing. But this is all absolutely awesome work @ozelot379. |
@Borewit Is this correct and should I commit these files too? |
|
Part of v7.0.0 |
🚀 |
category
: Podcast CategoryhdVideo
: iTunes Video Quality (2=Full HD, 1=HD, 0=SD)keywords
: Podcast Keywordsmovement
: MovementmovementIndex
: Movement Index/Total, e.g.{no: 1, of: 2}
movementTotal
: The total number of movementspodcastId
: Podcast IdentifiershowMovement
: Show Movementstik
: iTunes Media Type (1=Normal, 2=Audiobook, 6=Music Video, 9=Movie, 10=TV Show, 11=Booklet, 14=Ringtone https://github.com/sergiomb2/libmp4v2/wiki/iTunesMetadata#user-content-media-type-stiksubtitle
asmultiple
to match return typestring[]
(May a breaking change)description
typecompilation
andpodcast
boolean
type (string
before) (May a breaking change)test/samples/zeroes.flac
metadata.common.composersort
has been changed to a singleton (May a breaking change)ID3:
CaseInsensitiveTagMap
, ID3v24 is already (May a breaking change)MVNM
tomovement
MVIN
(1 field) tomovementIndex
PCS
andPCST
topodcast
(Already exists for MP4)TCAT
tocategory
TCP
tocompilation
(Already exists for ID3>2.2 and for MP4)TDES
todescription
TDR
andTDRL
todate
(Already exists for MP4)TGID
topodcastId
TKWD
tokeywords
TS2
toalbumartistsort
(Already exists for ID3>2.2 and for MP4)TSA
toalbumsort
(Already exists for ID3>2.2 and for MP4)TSC
tocomposersort
(Already exists for ID3>2.2 and for MP4)TSP
toartistsort
(Already exists for ID3>2.2 and for MP4)TST
totitlesort
(Already exists for ID3>2.2 and for MP4)WFD
andWFED
topodcasturl
(Already exists for MP4)TOT
fromwork
tooriginalalbum
(May a breaking change)hdVideo
showMovement
stik
work
MP4:
CaseInsensitiveTagMap
(May a breaking change)©com
tocomment
©cpy
tocopyright
©mvn
tomovement
©mvi
/©mvc
(2 fields) tomovementIndex
andmovementTotal
©wrk
towork
catg
tocategory
egid
topodcastId
hdvd
tohdVideo
keyw
tokeywords
shwm
toshowMovement
stik
tostik
desc
fromdescription
tosubtitle
for differentiate withldesc
(May a breaking change)