Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop AMR support #2322

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Drop AMR support #2322

merged 1 commit into from
Jan 13, 2025

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Jan 13, 2025

Reverse #798, AMR is not a suitable format to support. Parsing is very expensive, and we can only calculate the duration. Better to use an AMR decoder for that purpose.

Resolves #2317

@Borewit Borewit self-assigned this Jan 13, 2025
@coveralls
Copy link

coveralls commented Jan 13, 2025

Coverage Status

coverage: 97.002% (+0.04%) from 96.967%
when pulling 15b5191 on drop-amr-support
into 8bd601c on master.

@Borewit Borewit merged commit 97e09ea into master Jan 13, 2025
28 checks passed
@Borewit Borewit deleted the drop-amr-support branch January 13, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMR is to slow to parse via a web-stream
2 participants