Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loadMusicMetadata() typing for CommonJS (hack) #2234

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add loadMusicMetadata() typing for CommonJS (hack) #2234

merged 1 commit into from
Aug 30, 2024

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Aug 30, 2024

Workaround for typing issue as discussed #1357 (comment)

@Borewit Borewit added the improvement Improvement of existing functionality label Aug 30, 2024
@Borewit Borewit self-assigned this Aug 30, 2024
@coveralls
Copy link

coveralls commented Aug 30, 2024 •
edited
Loading

Coverage Status

coverage: 97.078%. remained the same
when pulling 19d2e38 on cjs-type-hack
into c9802c4 on master.

@Borewit Borewit merged commit 6cfd1c7 into master Aug 30, 2024
25 checks passed
@Borewit
Copy link
Owner Author

Borewit commented Aug 30, 2024

Part of v10.3.1

@Borewit Borewit deleted the cjs-type-hack branch January 13, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Borewit Borewit

Labels
improvement Improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borewit @coveralls