Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining Node.js Buffer dependencies #2142

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Remove remaining Node.js Buffer dependencies #2142

merged 1 commit into from
Jul 12, 2024

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Jul 12, 2024 •
edited
Loading

Changes:

  1. Remove remaining Buffer usages.
  2. Add lint rule to prevent Node.js Buffer usage.

Resolves: #2141

@Borewit Borewit added the bug Bug, will addressed with high priority label Jul 12, 2024
@Borewit Borewit self-assigned this Jul 12, 2024
@coveralls
Copy link

coveralls commented Jul 12, 2024 •
edited
Loading

Coverage Status

coverage: 96.5% (+0.07%) from 96.433%
when pulling 3f8aa15 on remove-remaing-buffer-usage
into 84f234a on master.

@Borewit Borewit force-pushed the remove-remaing-buffer-usage branch from 43ba3eb to 5f29c64 Compare July 12, 2024 09:29
@Borewit Borewit changed the title Remove remaining Buffer usages. Remove remaining Node.js Buffer dependencies Jul 12, 2024
@Borewit Borewit force-pushed the remove-remaing-buffer-usage branch 3 times, most recently from 0c44559 to 855bf0a Compare July 12, 2024 09:50
@Borewit
Remove remaining Buffer usages.
3f8aa15 
Add lint rule to prevent global Buffer usage.
@Borewit Borewit force-pushed the remove-remaing-buffer-usage branch from 855bf0a to 3f8aa15 Compare July 12, 2024 09:57
@Borewit Borewit merged commit d6c2755 into master Jul 12, 2024
17 of 18 checks passed
@Borewit Borewit deleted the remove-remaing-buffer-usage branch July 12, 2024 10:01
@Borewit
Copy link
Owner Author

Borewit commented Jul 12, 2024 •
edited
Loading

Part of v9.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Borewit Borewit

Labels
bug Bug, will addressed with high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

music-metadata 9.0.0 has still Buffer dependencies
2 participants
@Borewit @coveralls