Support "common" (and not only "native") for .webm files

[martpie]

Feature Request

Hello 👋

Thank you again for this great library!

Debugging martpie/museeks#590, I realized that maybe a better fix would be to fix it at the package level, rather than the application level, do you think it would be do-able?

Sample files: https://drive.google.com/drive/folders/1m_VdewpLCW5SyKF3QT4n1FtS-D6Dd4iC

[Borewit]

If something needs to get fixed or augmented, this is the right place and welcome back @martpie.

So I basically see 2 tags which possibly could be mapped to common:

Webm Tag	common
50:ARTIST	albumartist
50:GENRE	genre

I could not find any information what this 50: prefix means or where it comes from.

Foobar2000 seems to understand these tags so I followed their example. So I follow their example. That is why I propose to map 50:ARTIST to albumartis and not to artist

[Borewit]

2277c90 would make the following test pass:

describe('#835', () => {

  it('should parse "Dance Money.webm"', async () => {

    const filePath = path.join(issue_path, '#835', 'Dance Money.webm');

    const {format, common, native} = await mm.parseFile(filePath, {duration: true});
    assert.strictEqual(format.container, 'EBML/webm', 'format.container');
    assert.strictEqual(format.codec, 'OPUS', 'format.codec');

    assert.deepStrictEqual(common.genre, ['hip hop'], 'common.genre');
  });

  it('should parse "Let Me Down Slowly.webm"', async () => {

    const filePath = path.join(issue_path, '#835', 'Let Me Down Slowly.webm');

    const {format, common, native} = await mm.parseFile(filePath, {duration: true});
    assert.strictEqual(format.container, 'EBML/webm', 'format.container');
    assert.strictEqual(format.codec, 'OPUS', 'format.codec');

    assert.strictEqual(common.title, 'Let Me Down Slowly', 'common.title');
    assert.strictEqual(common.albumartist, 'Alec Benjamin', 'common.albumartist');
  });

  it('should parse "tagged.webm"', async () => {

    const filePath = path.join(issue_path, '#835', 'tagged.webm');

    const {format, common, native} = await mm.parseFile(filePath, {duration: true});
    assert.strictEqual(format.container, 'EBML/webm', 'format.container');
    assert.strictEqual(format.codec, 'OPUS', 'format.codec');

    assert.isUndefined(common.title, 'common.title');
    assert.strictEqual(common.albumartist, 'son go ku', 'common.title');
  });

});

[Borewit]

Is this sufficient, did I miss anything @martpie?

[martpie]

I think it looks very good like that! @haidang666 what do you think?

[haidang666]

look good, btw ffmpeg was used to edit that metadata, the 50: maybe related in the structure in webm

[Borewit]

The 50: is caused by a bug in this Matroska parser, there is no default value type in these tags (type, is album, track etc...). It should fall back to album as the default, but it turns the type ID instead of the string value.

Another related bug I fixed in #836.