Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip HTML tags from the note title #880

Merged
merged 1 commit into from
Sep 22, 2017

Conversation

xxdavid
Copy link
Contributor

@xxdavid xxdavid commented Sep 21, 2017

I'd like to style my headings with a color. The problem is the HTML tags aren't stripped from the title. This PR fixes it.

Before:
Before

After:
After

@BoostnoteBot
Copy link
Collaborator

Be sure to be changed browser/main/Detail/SnippetNoteDetail.js.

@kazup01 kazup01 self-requested a review September 22, 2017 04:04
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 4ebd503 into BoostIO:master Sep 22, 2017
@kazup01
Copy link
Member

kazup01 commented Sep 22, 2017

Merged. Thanks for your contribution @xxdavid !🎉

@kazup01
Copy link
Member

kazup01 commented Sep 22, 2017

Would you like to try Boostnote Mobile ? @xxdavid

@xxdavid
Copy link
Contributor Author

xxdavid commented Sep 22, 2017

Thank you. :)

@xxdavid
Copy link
Contributor Author

xxdavid commented Sep 22, 2017

@kazup01, sorry, I don't get it... What do you mean by trying?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants