Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the attachment name in attachment page (#714) #715

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

coderkk
Copy link
Contributor

@coderkk coderkk commented Dec 5, 2020

#714 Reuse the attachment in another page. It also can search which pages use this image by copy the attachment name and paste it to the search box.

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2020

CLA assistant check
All committers have signed the CLA.

@coderkk coderkk changed the title Copy the attachment name in attachment page #714 Copy the attachment name in attachment page (#714) Dec 5, 2020
@Rokt33r
Copy link
Member

Rokt33r commented Dec 6, 2020

@coderkk Can you sign our CLA? Then I can merge it!

@Rokt33r Rokt33r added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Dec 6, 2020
@coderkk
Copy link
Contributor Author

coderkk commented Dec 7, 2020

I have signed, but it still show pending.

@Rokt33r
Copy link
Member

Rokt33r commented Dec 7, 2020

@coderkk
I think the problem is caused by your git setting. Every commit is having an email of all committers. Apparently, the email in this commit doesn't match the other one, which is attached to your Github account. Please check this article.
https://docs.github.com/en/free-pro-team@latest/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address

You can resolve this issue in two ways.

  1. Register your git client email to Github
  2. Configure your git client email and commit again(In this case, you should do a hard reset and push forcefully to replace the current commit completely.)

@coderkk
Copy link
Contributor Author

coderkk commented Dec 7, 2020

OK @Rokt33r, I will recheck my repo. Thanks

@coderkk
Copy link
Contributor Author

coderkk commented Dec 8, 2020

@Rokt33r can I cancel this request and submit new request again?

@Rokt33r
Copy link
Member

Rokt33r commented Dec 14, 2020

@coderkk
Absolutely, you can. But please try this instruction. I'd like you to learn how to fix it by yourself.

# Reset all commits in this PR while keeping all changes (1c07ff07 is the base commit of this PR before you made any changes)
git reset --mixed 1c07ff07
# Commit the changes again
git add -A 
git commit -a
# Execute forced push to overwrite all commits in this pr
git push -f

This procedure will let you make a clean commit with the same changes.

@coderkk coderkk force-pushed the copy-attachment-name branch from fd03a57 to 63962bf Compare December 15, 2020 00:14
@coderkk
Copy link
Contributor Author

coderkk commented Dec 15, 2020

@Rokt33r All right, thanks

@Rokt33r Rokt33r merged commit 6fb01b6 into BoostIO:master Dec 17, 2020
@Rokt33r
Copy link
Member

Rokt33r commented Dec 17, 2020

@coderkk Thanks!

@Rokt33r Rokt33r added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Dec 17, 2020
@Rokt33r Rokt33r added this to the v0.12.0 milestone Dec 17, 2020
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants