feat: Number of notes in folders #616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@laudep I've made quite lots of changes from v0.10. Do you think you can resolve the conflicts? If you don't have time, I probably start working on this from Nov 11th. |
Done 👍 |
Rokt33r
requested changes
Dec 14, 2020
| @@ -50,6 +50,13 @@ const FolderListFragment = ({ | |||
| ) | |||
| }, [folderPathnames, storageId, sideNavOpenedItemSet]) | |||
|
|
|||
| const getFolderNoteCount = (folderPathname: string): number => | |||
There was a problem hiding this comment.
We cannot use this method everywhere, this will cause each folder nav item component to iterate every note for every change. But populated folders in our hook state are having folderIdSet props. This should be useful to show number of notes in a folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add numbers next to folders & tags displaying the amount of notes.
Display count for:
Solves #602