Add tooltips to the note detail toolbar #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rokt33r
requested changes
Aug 28, 2020
Rokt33r
requested changes
Sep 2, 2020
| }: NoteDetailFolderNavigatorProps) => { | ||
| interface FolderNavItemProps { | ||
| path: string | ||
| children?: React.ReactNode |
| noteFolderPathname, | ||
| }: NoteDetailFolderNavigatorProps) => { | ||
| interface FolderNavItemProps { | ||
| path: string |
There was a problem hiding this comment.
storageId, storageName, noteId, noteFolderPathname are already resolved from parent component. We don't need to parse again. It will make our app slower.
| ? getFolderTooltip(folderName) | ||
| : getStorageTooltip(storageName) | ||
|
|
||
| const isActive = |
| return ( | ||
| <FolderNavItemButton | ||
| title={tooltip} | ||
| href={path} |
There was a problem hiding this comment.
It is a button, not an anchor element
|
|
||
| const tooltip = folderName | ||
| ? getFolderTooltip(folderName) | ||
| : getStorageTooltip(storageName) |
There was a problem hiding this comment.
It is a folder nav item, not a storage item.
| > | ||
| {storageName} | ||
| </FolderNavItem> | ||
| <FolderNavItem path={`/app/storages/${storageId}/notes/${noteId}`} /> |
There was a problem hiding this comment.
I'd like to introduce another component
|
I'll resolve the change requests by myself! Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #552