-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folder rearranging feature(#349) #396
Conversation
- Add validation - Refactoring (code format, newline code) - Add @types package (react-sortable-tree and theme)
@zeroclock |
@Rokt33r |
Why hasn't this been merged yet? This is a great feature to implement |
In my opinion, it would be better to not have an 'update folders' button, but rather it updates every time you drop the folder after a move. So being able to update the folders by drag and drop on the left, without needing an edit state (on the right). This would be consistent with how most people would expect, and less prone to conflicts if the app allows concurrent collaboration (or ever will). Also some people might forget or not notice to click. And less clicks, the better. |
@peoray Sorry for the delay. I still need to think about how to introduce this feature properly. |
@ChrisCorrigan I agree with you. Folder orders should be managed by dragging and drop in the navigator. FYI, we're already trying to provide concurrent collaboration. And the app has the rearranging feature in real-time. Please check this out http://boosthub.io/ The app will be integrated into this app one day. |
It's been fixed in other prs. Sorry for my late response. |
related issue: #349
Added folder tree component to the storage edit page.
Folder pathnames are transformed to folderTreeData.
Example
↓
By using this data and react-sortable-tree library, we can get each folder's before & after pathname.
(Please try to push the
update folders
button after rearranging folders.)debug log
Todos:
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor