Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort rules #5457

Merged
merged 17 commits into from
Feb 11, 2025
Merged

Sort rules #5457

merged 17 commits into from
Feb 11, 2025

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Jan 30, 2025 •
edited
Loading

Allows centrally managed (admin) sets of sort rules which can be applied to books.

Related to #2065, touches upon #1777

Todo

  • Book level control UI
    • However done, consider how this is reflected in book sort UI
  • Consider what to do on sort set change (reapply to all assigned books)?
  • Better delete UX? (control/visibility of assigned books)
  • Show assigned books?
  • CLI to mass apply to books?
  • Consider effect of timestamp touching.
  • Testing
    • Test sort set settings screens/actions
    • Test actual sort events (page creation, chapter update etc..).

Doc Updates

  • Update organising content page with guidance on sort rules, and maybe details of sort options.
  • Upgrade notice: Basic sort changes will no longer touch the update date of chapters/pages.
  • Commands: Document bookstack:assign-sort-rule

@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Jan 30, 2025
@ssddanbrown ssddanbrown self-assigned this Jan 30, 2025
@ssddanbrown
Sorting: Started sort set routes and form
bf8a84a
@ssddanbrown
Sorting: Added sort set form manager UI JS
d28278b 
Extracted much code to be shared with the shelf books management UI
@ssddanbrown
Sorting: Finished main sort set CRUD work
b897af2
@ssddanbrown
Sorting: Connected up default sort setting for books
7093daa
@ssddanbrown
Sorting: Added book autosort logic
c13ce18
@ssddanbrown
Sorting: Improved sort set display, delete, added action on edit
ccd9468 
- Changes to a sort set will now auto-apply to assinged books (basic
  chunck through all on save).
- Added book count indicator to sort set list items.
- Deletion now has confirmation and auto-handling of assigned
  books/settings.
@ssddanbrown
Sorting: Added auto sort option to book sort UI
ec79517 
Includes indicator on books added to sort operation.
@ssddanbrown
Sorting: Addded command to apply sort sets
37d020c
@ssddanbrown
Sorting: Added tests to cover AssignSortSetCommand
69683d5
@ssddanbrown
Sorting: Split out test class, added book autosort tests
a657012 
Just for test view, actual functionality of autosort on change still
needs to be tested.
@ssddanbrown
Sorting: Covered sort set management with tests
a208c46
@ssddanbrown
Sorting: Renamed sort set to sort rule
b9306a9 
Renamed based on feedback from Tim and Script on Discord.
Also fixed flaky test
@ssddanbrown
Sorting: Updated sort set command, Changed sort timestamp handling
7bd8931 
- Renamed AssignSortSetCommand to AssignSortRuleCommand, updated
  contents and testing.
- Updated sorting operations to not update timestamps if only priority
  is changed.
@ssddanbrown ssddanbrown changed the title Sort sets Sort rules Feb 11, 2025
@ssddanbrown ssddanbrown merged commit a7de251 into development Feb 11, 2025
15 of 19 checks passed
@ssddanbrown ssddanbrown deleted the sort_sets branch February 11, 2025 15:41
This was referenced Feb 11, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ssddanbrown ssddanbrown

Labels
📖 Docs Update 🏭 Back-End 🛠️ Enhancement 🔨 Feature Request
Milestone
Next Feature Release
Development

Successfully merging this pull request may close these issues.
1 participant
@ssddanbrown