Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebLN enable() should not expect an object? #229

Closed
otech47 opened this issue Jul 27, 2023 · 1 comment · Fixed by #230
Closed

WebLN enable() should not expect an object? #229

otech47 opened this issue Jul 27, 2023 · 1 comment · Fixed by #230

Comments

@otech47
Copy link
Contributor

otech47 commented Jul 27, 2023

According to the spec at webln.guide the enable function has a return type of void

boltz.exchange has 2 instances calling window.webln.enable() and both are expecting it to return an object with a enabled field that must be truthy in order for webLN to proceed and work properly

Seems Alby as a WebLN provider is also deviating from this spec since the webln object injected by Alby has an enable function that does not have a void return type, which is probably why the logic below was written this way

Screenshot 2023-07-27 at 1 44 10 PM

Not sure if the spec should change or this implementation should change but WebLN providers who implement enable according to the spec will not be compatible with boltz.exchange due to this inconsistency
@otech47 otech47 changed the title WebLN enable() should not expect an object WebLN enable() should not expect an object? Jul 27, 2023
@otech47 otech47 mentioned this issue Jul 27, 2023
Closed
otech47 added a commit to otech47/boltz-web-app that referenced this issue Jul 27, 2023
@otech47
fix: enable() should not expect an object
ad8630d 
BoltzExchange#229
@otech47 otech47 mentioned this issue Jul 27, 2023
Merged
otech47 added a commit to setlife-network/boltz-web-app that referenced this issue Jul 27, 2023
@otech47
fix: enable() should not expect an object (#1)
09d724d 
BoltzExchange#229
@otech47 otech47 mentioned this issue Jul 27, 2023
Merged
otech47 added a commit to setlife-network/boltz-web-app that referenced this issue Jul 28, 2023
@otech47
fix: enable() should not expect an object
31c221d 
BoltzExchange#229

amended: fixed linting errors
michael1011 pushed a commit that referenced this issue Jul 28, 2023
@otech47
fix: WebLN enable() should not expect an object (#230)
d0a3955 
#229

amended: fixed linting errors
@humansinstitute
Copy link

humansinstitute commented Aug 16, 2023 •
edited
Loading

Hi All - when I test this in Fedi App I'm still getting failures trying to pay via webLN is this deployed on boltz.exchange?

michael1011 pushed a commit that referenced this issue Aug 16, 2023
@otech47 @michael1011
fix: WebLN enable() should not expect an object (#230)
cff18e4 
#229

amended: fixed linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: enable() should not expect an object setlife-network/boltz-web-app
2 participants
@otech47 @humansinstitute