Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hold invoice overpayment #414

Merged
merged 8 commits into from
Oct 30, 2023
Merged

fix: hold invoice overpayment #414

merged 8 commits into from
Oct 30, 2023

Conversation

michael1011
Copy link
Member

@michael1011 michael1011 commented Oct 22, 2023 •
edited
Loading

Closes #413

@michael1011 michael1011 force-pushed the hold-fixes branch 3 times, most recently from 1aae1ba to d056eed Compare October 22, 2023 23:01
@kilrau kilrau changed the title Hold invoice fixes fix: hold invoice overpayment Oct 24, 2023
@michael1011 michael1011 marked this pull request as ready for review October 29, 2023 18:22
@kilrau
Copy link
Member

kilrau commented Oct 30, 2023

🔥

@kilrau kilrau self-requested a review October 30, 2023 16:14
kilrau
kilrau approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

  • 3x overpayment - rejected
  • simultaneously from two different wallets - one went through, one rejected

LGTM

@michael1011 michael1011 merged commit 383d494 into master Oct 30, 2023
4 checks passed
@michael1011 michael1011 deleted the hold-fixes branch October 30, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilrau kilrau kilrau approved these changes

Assignees

@michael1011 michael1011

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLN Hold Invoice Plugin: Handle Overpayments
2 participants
@michael1011 @kilrau