Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nested Computations (function calls) with appendComputation #27

Open
riftEmber opened this issue Sep 10, 2021 · 3 comments
Open

Add support for nested Computations (function calls) with appendComputation #27

riftEmber opened this issue Sep 10, 2021 · 3 comments
Assignees
@riftEmber

Comments

@riftEmber
Copy link
Member

No description provided.

@riftEmber riftEmber self-assigned this Sep 10, 2021
@riftEmber
Copy link
Member Author

Working on branch append-computation

riftEmber added a commit that referenced this issue Oct 24, 2021
@riftEmber
Begin work on support for nested functions #27
a51cfa7 
- No testing yet
- Does nothing with return values
- Only detects function calls in statements that are just a function
  call.
@riftEmber riftEmber changed the title Add good support for nested Computations (function calls) Add support for nested Computations (function calls) with appendComputation Oct 24, 2021
riftEmber added a commit that referenced this issue Oct 24, 2021
@riftEmber
Begin work on support for nested functions #27
6022eb9 
- Due to the nature of appendComputation, this required changing to build up
  the Computation as it is processed, with Stmts added one at a time instead
  of all at the end.
- No testing yet
- Does nothing with return values
- Only detects function calls in statements that are just a function
  call
riftEmber added a commit that referenced this issue Oct 25, 2021
@riftEmber
Add basic nesting test #27
446beb5
riftEmber added a commit that referenced this issue Oct 25, 2021
@riftEmber
Begin work on support for nested functions #27
b33b4cd 
- Due to the nature of appendComputation, this required changing to build up
  the Computation as it is processed, with Stmts added one at a time instead
  of all at the end.
- No testing yet
- Does nothing with return values
- Only detects function calls in statements that are just a function
  call
riftEmber added a commit that referenced this issue Oct 25, 2021
@riftEmber
Add basic nesting test #27
c8d3394 
Includes removing expecting zero-padded execution schedules.
Code that zero-padded executions schedules has already been removed,
because with appendComputation calls it is now difficult to enforce.
Additionally, IEGenLib does this for us now.
@riftEmber
Copy link
Member Author

Merged first iteration of work. I've gotten to the point where effectively finishing this is blocked by better support for data spaces and return values, so I'm going to stop now and come back to it when those are done.

riftEmber added a commit that referenced this issue Nov 25, 2021
@riftEmber
Add positionContext save/restore around recursion into sub computation …
8d6f76e 
…#27
@riftEmber
Copy link
Member Author

Next step is to process function calls in a statement like x = (foo() + 3) * bar(4). Perhaps this can be done by modifying the method that finds accesses in a compound expression.

riftEmber added a commit that referenced this issue Nov 26, 2021
@riftEmber
Add support for counting return values as read data spaces #27
f7e62c0 
- Returned functionality for extracting data accesses to
  processSingleStmt
- Adds ComputationBuilder::processComplexExpr function, which locates both
  potential data accesses and function calls (which in turn can return
  accessed spaces)
- This function relies on the new Utils::collectComponentsFromCompoundExpr
  function, which collects both potential data accesses and function
  calls from potentially complex expressions. It is used in various ways, with
  the values filtered down by the caller to what they're interested in.
@riftEmber riftEmber mentioned this issue Nov 26, 2021
Merged
riftEmber added a commit that referenced this issue Nov 26, 2021
@riftEmber
Add better inlining + support using return values as data spaces #27
624cfef 
- Returned functionality for extracting data accesses to
  processSingleStmt
- Adds ComputationBuilder::processComplexExpr function, which locates both
  potential data accesses and function calls (which in turn can return
  accessed spaces)
- This function relies on the new Utils::collectComponentsFromCompoundExpr
  function, which collects both potential data accesses and function
  calls from potentially complex expressions. It is used in various ways, with
  the values filtered down by the caller to what they're interested in.
riftEmber added a commit that referenced this issue Nov 26, 2021
@riftEmber
Add better inlining + support using return values as data spaces #27
0d64f18 
- Returned functionality for extracting data accesses to
  processSingleStmt
- Adds ComputationBuilder::processComplexExpr function, which locates both
  potential data accesses and function calls (which in turn can return
  accessed spaces)
- This function relies on the new Utils::collectComponentsFromCompoundExpr
  function, which collects both potential data accesses and function
  calls from potentially complex expressions. It is used in various ways, with
  the values filtered down by the caller to what they're interested in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riftEmber riftEmber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@riftEmber