Fix ABI Decoding #135
Merged
Fix ABI Decoding #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 70.86% 74.89% +4.03%
==========================================
Files 63 64 +1
Lines 4438 4490 +52
==========================================
+ Hits 3145 3363 +218
+ Misses 1293 1127 -166
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Florian-S-A-W
approved these changes
Oct 21, 2022
koraykoska
added a commit
that referenced
this pull request
Aug 1, 2023
* fix: decoding of single tuple types * chore: cleanup abi decoder class * fix: rigorous testing for abi decoding Co-authored-by: Florian Winkler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABI tuple decoding was broken for multidimensional arrays (and not implemented for multidimensional tuple arrays). I fixed it and included a few test cases for the edge cases.