-
Notifications
You must be signed in to change notification settings - Fork 72
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: Boeing/config-file-validator
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.6.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: Boeing/config-file-validator
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.7.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 16 commits
- 60 files changed
- 8 contributors
Commits on Mar 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 54b6781 - Browse repository at this point
Copy the full SHA 54b6781View commit details
Commits on Apr 10, 2024
-
Fix Go Report Card Issues (#131)
* Fix ineffassign * Fix ineffassign * Fix misspell * Fix gocyclo * Return error * @ccoVeille s suggestion * Returning error Co-authored-by: ccoVeille <[email protected]> * Removed interface{} to solve type problems. > > Co-authored-by: ccoVeille <[email protected]> * Comment Co-authored-by: ccoVeille <[email protected]> * Fix file output on quiet flag * Delete test/result.json * Changed 1 test * Test fix * remove test.txt * Coverage test Co-authored-by: ccoVeille <[email protected]> --------- Co-authored-by: ccoVeille <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9006fce - Browse repository at this point
Copy the full SHA 9006fceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fbc213 - Browse repository at this point
Copy the full SHA 4fbc213View commit details
Commits on Apr 11, 2024
-
* chore: format files before working on them files were formatted with gofumpt * fix: make sure to always wrap errors This is the only way to be able to catch a specific error with errors.Is in the code calling the method * fix: errors have to be manipulated with care The existing code could lead to errors with wrapped errors - using `if err == whatever` don't catch wrapped errors - using type assertion could lead to panic * fix: error returned by reporters must be handled * fix: misuage of WalkDirFunc * chore: fix some typos and error in the struct * chore: remove unused receivers The code is then clearer * chore: Replace all interface{} by any any is available since Go 1.18, it makes code clearer. * chore: use uppercase for JSON, XML, and YAML acronyms * chore: use simpler name for cli Option an option of cli doesn't need to be named cli.CLIOption * chore: avoid shadowing import when importing something from cli package, we shouldn't name a variable cli * chore: avoid useless else The code is clearer to understand. * chore: remove unused assertErrorIs and accept assert.Error
Configuration menu - View commit details
-
Copy full SHA for 6d21ca3 - Browse repository at this point
Copy the full SHA 6d21ca3View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb6358e - Browse repository at this point
Copy the full SHA bb6358eView commit details
Commits on Apr 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c8df506 - Browse repository at this point
Copy the full SHA c8df506View commit details
Commits on May 29, 2024
-
Enable openssf scorecard (#151)
* initialize openssf scorecard * test-scorecard-on-PR * add scorecard badge to README * increasing timeout in golangci workflow * Add scorecard badge to index.md * Update .github/workflows/scorecard.yml Co-authored-by: Jamie Davidson <[email protected]> * Update scorecard.yml --------- Co-authored-by: Jamie Davidson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1730fbe - Browse repository at this point
Copy the full SHA 1730fbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fdf93a - Browse repository at this point
Copy the full SHA 2fdf93aView commit details -
Improve Scorecard scores (#152)
* add openssf best practices badge * adding security * remove binary file * improving workflow security * addings SHAs to base containers * fixing workflows * fixing workflows * updating security text
Configuration menu - View commit details
-
Copy full SHA for f28a04d - Browse repository at this point
Copy the full SHA f28a04dView commit details
Commits on May 30, 2024
-
ci(goreportcard): Add step for goreportcard check (#149)
Go report card for repo: https://goreportcard.com/report/github.com/Boeing/config-file-validator Fixes #120 Signed-off-by: Bhargav Ravuri <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7203891 - Browse repository at this point
Copy the full SHA 7203891View commit details
Commits on Aug 3, 2024
-
EditorConfig file type #145 (#157)
* EditorConfig file type * Removed deprecated ParseBytes function * Update pkg/filetype/file_type.go --------- Co-authored-by: Clayton Kehoe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for be200ae - Browse repository at this point
Copy the full SHA be200aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2982c50 - Browse repository at this point
Copy the full SHA 2982c50View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9a4db4 - Browse repository at this point
Copy the full SHA d9a4db4View commit details -
small optimization for fsfinder (#136)
* changed []string to map[string]struct{} in FileSystemFinder struct fields because of optimization (arrays were used only to check the occurrence of an element) * Changed field Extensions type in FileType from []string to map[string]struct{} * added requested changes * small refactoring of findOne func * fixd the return value * get back to trimprefix func * cleanup * fsfinder optimization * i hope it fixed * removed unnecessary calls to filepath.Abs * Apply suggestions from code review --------- Co-authored-by: Yaroslav <=> Co-authored-by: Clayton Kehoe <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e601c40 - Browse repository at this point
Copy the full SHA e601c40View commit details
Commits on Aug 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c502b13 - Browse repository at this point
Copy the full SHA c502b13View commit details
Commits on Aug 13, 2024
-
ci: add the permission to release assets (#160)
The release v1.7.0 failed due to the permission error. https://github.com/Boeing/config-file-validator/actions/runs/10362649156/job/28684983356#step:6:284 ``` + github-assets-uploader -logtostderr -f ../validator-v1.7.0-linux-amd64.tar.gz -mediatype application/gzip -repo Boeing/config-file-validator -token *** -tag=v1.7.0 -releasename= -retry 3 W0813 02:34:38.260789 1654 main.go:48] Upload asset error, will retry in 4s: POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration [] W0813 02:34:42.775738 1654 main.go:48] Upload asset error, will retry in 9s: POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration [] E0813 02:34:52.242572 1654 err_exit.go:11] POST https://uploads.github.com/repos/Boeing/config-file-validator/releases/169879682/assets?name=validator-v1.7.0-linux-amd64.tar.gz: 403 Resource not accessible by integration [] ``` The permission `contents: write` is required, but it was removed by f28a04d#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34 . So this commit adds the permission.
Configuration menu - View commit details
-
Copy full SHA for 10a6def - Browse repository at this point
Copy the full SHA 10a6defView commit details
There are no files selected for viewing