Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python API #30

Merged
merged 17 commits into from
Dec 20, 2024
Merged

Python API #30

merged 17 commits into from
Dec 20, 2024

Conversation

grst
Copy link
Collaborator

@grst grst commented Oct 4, 2024 •
edited
Loading

Defines a Python API, e.g. to be used from jupyter notebooks.

Close #11
Close #67

  • Implement public Python API

apeltzer
apeltzer approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@grst grst marked this pull request as draft October 4, 2024 20:41
@tschwarzl tschwarzl marked this pull request as ready for review October 16, 2024 11:05
@grst

This comment was marked as outdated.

Sign in to view
@grst grst closed this Oct 17, 2024
@grst grst mentioned this pull request Oct 25, 2024
Closed
@grst grst reopened this Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-20 13:59 UTC

grst added 4 commits December 17, 2024 13:26
@grst
Refactor
5b80c01 
* Make CLI separate module
* Defer imports for CLI
* Make all modules private that are not part of the public API
@grst
Adjust tests after refactoring
4080f55
@grst
Update CHANGELOG
a54626b
@grst
Sort CLI commands alphabetically
bb24186
@grst grst merged commit 2ab70b3 into main Dec 20, 2024
5 checks passed
@grst grst deleted the python-api branch December 20, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

@tschwarzl tschwarzl tschwarzl approved these changes

@DSchreyer DSchreyer Awaiting requested review from DSchreyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Speed up dso by deferring imports Python API to match R package functionalities
3 participants
@grst @apeltzer @tschwarzl