-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding in CI testing #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Some minor comments, but the overall structure looks fine
.github/workflows/deploy_pypi.yml
Outdated
@@ -0,0 +1,30 @@ | |||
name: Publish DSO to PyPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you settle on a name on PyPI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't so far 😉
Unit tests still failing, something weird with quarto-cli: |
I'd suspect something was changed in a recent quarzo Version. I can look into it the next days |
Yeah no worries, I'll leave this PR open and you can adjust as you like 👍🏻 Your other points were addressed hopefully, we can take it from there |
Apart from the name lgtm 👌 |
Stripped it down a bit (see #22 for follow-up). Need to settle on a name for pypi, but we could even do so after merging this. |
This attempts at adding workflows for CI for the following: