Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in CI testing #18

Merged
merged 43 commits into from
Sep 22, 2024
Merged

Adding in CI testing #18

merged 43 commits into from
Sep 22, 2024

Conversation

apeltzer
Copy link
Member

This attempts at adding workflows for CI for the following:

  • Release to PyPi
  • Linting Bot that fixes linting issues upon invocation
  • Linting based on our pre-commit settings
  • Screenshots via rich-codex ;-) - can be used in the docs then
  • Runs the unit tests we define via pytest

@DSchreyer DSchreyer requested review from grst and DSchreyer September 18, 2024 11:47
Copy link
Collaborator

@DSchreyer DSchreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Some minor comments, but the overall structure looks fine

@@ -0,0 +1,30 @@
name: Publish DSO to PyPI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you settle on a name on PyPI?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't so far 😉

@apeltzer
Copy link
Member Author

Unit tests still failing, something weird with quarto-cli: error: the argument '--v8-flags[=<v8-flags>...]' cannot be used multiple times

@grst
Copy link
Collaborator

grst commented Sep 19, 2024

I'd suspect something was changed in a recent quarzo Version. I can look into it the next days

@apeltzer
Copy link
Member Author

I'd suspect something was changed in a recent quarzo Version. I can look into it the next days

Yeah no worries, I'll leave this PR open and you can adjust as you like 👍🏻 Your other points were addressed hopefully, we can take it from there

@apeltzer
Copy link
Member Author

Apart from the name lgtm 👌

@grst grst changed the title [WIP] Adding in CI testing Adding in CI testing Sep 21, 2024
@grst
Copy link
Collaborator

grst commented Sep 21, 2024

Stripped it down a bit (see #22 for follow-up).
Autofixing seems to work, checks are passing now.

Need to settle on a name for pypi, but we could even do so after merging this.

@apeltzer apeltzer merged commit 614a0ba into main Sep 22, 2024
2 checks passed
@apeltzer apeltzer deleted the add-ci branch September 22, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants