Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of reload function #18

Merged
merged 13 commits into from
Oct 23, 2024
Merged

Implementation of reload function #18

merged 13 commits into from
Oct 23, 2024

Conversation

tschwarzl
Copy link
Contributor

Added a reload function.

Usage:
params = read_params("..stage_path..") reload(params)

This function will overwrite the dsoParams object passed on, based on the stage_path variable previously set by read_params.
Error handling is implemented as well.

@tschwarzl tschwarzl requested review from grst and DSchreyer October 22, 2024 20:42
Copy link
Collaborator

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, please just bump the version number accordingly.

CHANGELOG.md Outdated
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v0.4.5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an API addition and should therefore be 0.5.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, will do, thanks

version bump
version bump to 0.5.0
@tschwarzl tschwarzl requested a review from grst October 23, 2024 07:17
@tschwarzl tschwarzl closed this Oct 23, 2024
@tschwarzl tschwarzl reopened this Oct 23, 2024
@tschwarzl tschwarzl merged commit a10afdf into main Oct 23, 2024
@tschwarzl tschwarzl deleted the dev-reload branch October 23, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants