Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved compatibility with list casting operations and added unclassing to as.list #15

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

tschwarzl
Copy link
Contributor

@tschwarzl tschwarzl commented Oct 17, 2024

Closes #13

This improves the compatibility with list casting operations and other functionality by adding "list" to the class attribute.

Also overwritten as.list functionality to unclass and return pure list.

Added unit tests for the operations

@tschwarzl tschwarzl requested a review from DSchreyer October 17, 2024 09:53
Copy link
Collaborator

@DSchreyer DSchreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@DSchreyer DSchreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DSchreyer DSchreyer merged commit 6d8115b into main Oct 18, 2024
@DSchreyer DSchreyer deleted the dev-as-list branch October 18, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overwrite as.list
3 participants