Change life time of AWS servers from 4 to 6 years #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing double counting usage impacts and adding missing platform_aws_t4g
…-3.12 chore(python): upgrade to Python 3.12
|
I only have changed life time of the servers with the manufacturer equals AWS. So the servers with an empty manufacturer or Dell still have a life time of 4 years configured. I didn't change the server.csv in the test directory. If I do that 10 tests will fail. I think it is not necessary to update the tests because of that. |
|
Yes, you were right not to change the test file. We deliberately kept them separate to make it easier to change the data. |
|
I will release it this week |
da-ekchajzer
added a commit
that referenced
this pull request
Dec 13, 2024
Co-authored-by: David <[email protected]> Co-authored-by: Simon Shillaker <[email protected]> Co-authored-by: Simon Shillaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352