Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change base docker image to allow application startup #321

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

demeringo
Copy link
Collaborator

See #320

This works but there may be more optimized solutions.

@demeringo demeringo linked an issue Sep 27, 2024 that may be closed by this pull request
@da-ekchajzer
Copy link
Collaborator

Yeah ! Works for me. I think we used python-slim at first because the docker image was too big. Does this new base image still keep the image small ?

@demeringo
Copy link
Collaborator Author

I am pretty sure it is not good, we can compare and get insights with dive https://github.com/wagoodman/dive

Just we have to keep in mind that we compare differents versions (different deps).

@demeringo
Copy link
Collaborator Author

@da-ekchajzer I checked and the result is terrible: 1,7 GB 💣 (compared to around 500 MB before), so yes we clearly have to optimise before merge.

@demeringo
Copy link
Collaborator Author

demeringo commented Sep 27, 2024

I made a typo in the previous dockerfile which lead to reuse the same image in a 2 stages build.

Last commit separates images in the 2 stages and brings better results: 665 MB.

It can and should still be optimized but IMHO we could use this version for the time being.

@da-ekchajzer da-ekchajzer merged commit a554fdd into main Sep 27, 2024
@da-ekchajzer da-ekchajzer deleted the 320-docker-image-fails-to-start branch October 11, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker image fails to start
2 participants