Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 0.491 constant value from CPU die size #279

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

tibosmn
Copy link
Contributor

@tibosmn tibosmn commented Mar 6, 2024

Fixes #275

In the current computation of CPU die size, we include a constant value of 0.491 cm², derived from Green Cloud Computing (Figure 31, where the precise value is 0.49157).

Given that we now utilize a die size derived from a more extensive range of CPU models than those examined in the referenced study, the addition of such a constant is unnecessary to the computation die size = die size per core * number of cores.

Consequently, I suggest setting constant_core_impact to 0 to easily handle this issue. Please advise if I should remove core_impact altogether.

@tibosmn
Copy link
Contributor Author

tibosmn commented Mar 7, 2024

To ease future maintainability I removed constant_core_impact and core_impact altogether.

Also updated the unit tests, sry 🤡

@da-ekchajzer
Copy link
Collaborator

I've fixed the conflict linked to updating unit tests in the PR : #272.

@da-ekchajzer da-ekchajzer merged commit c048a98 into Boavizta:main Mar 7, 2024
1 check passed
@demeringo
Copy link
Collaborator

Important

This change may slightly update the values of embedded impacts returned by he API (e.g. Boavizta/cloud-scanner#467)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 0.491 in CPU die calculation
3 participants