Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: override DeviceFound and DeviceLost for passive monitoring #60

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 20, 2024

These are only used for debugging and they generate 10000s of callbacks per minute that flood the debug logs with useless data. Passive mode generated ~100x more log messages than active mode.

These are only used for debugging and they generate 10000s of callbacks
per minute that flood the debug logs with useless data
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.04%. Comparing base (61c3d97) to head (c2a5f3d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   74.81%   75.04%   +0.23%     
==========================================
  Files          12       12              
  Lines        1072     1082      +10     
  Branches      184      190       +6     
==========================================
+ Hits          802      812      +10     
  Misses        222      222              
  Partials       48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review August 20, 2024 16:38
@bdraco bdraco merged commit a802859 into main Aug 20, 2024
19 of 20 checks passed
@bdraco bdraco deleted the AdvertisementMonitor branch August 20, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant