Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure allocations are available if the adapter never makes any connections #131

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 31, 2025

Allocations would not return anything if the adapter had never made any connections

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.86%. Comparing base (1312bf7) to head (efffce9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   83.84%   83.86%   +0.01%     
==========================================
  Files          12       12              
  Lines        1201     1202       +1     
  Branches      139      139              
==========================================
+ Hits         1007     1008       +1     
  Misses        145      145              
  Partials       49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #131 will not alter performance

Comparing missing_allocations (efffce9) with main (1312bf7)

Summary

✅ 3 untouched benchmarks

@bdraco bdraco merged commit b3dfa48 into main Jan 31, 2025
25 checks passed
@bdraco bdraco deleted the missing_allocations branch January 31, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant